Fix CASE WHEN clause in AbstractReportRepository for PostgreSQL compatibility #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @curler7 Can you rebase your pull request ? |
|
Check! |
maximehuran
reviewed
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
CASE WHENclause in theAbstractReportRepositoryto ensure compatibility with PostgreSQL.Changes
The following change was made:
tax_adjustment.neutral = 1withtax_adjustment.neutral = true, addressing PostgreSQL's handling of boolean expressions and ensuring compatibility across both PostgreSQL and MySQL databases.Rationale
This fix prevents errors related to mismatched types during query execution in PostgreSQL, such as
operator does not exist: boolean = integer.Fixes #23